Allow local decorators via params #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
tmeasday
force-pushed
the
5781-document-decorator-changes
branch
from
fd02020
to
1e0016c
Compare
shilman
reviewed
Mar 1, 2019
| @@ -203,7 +203,12 @@ export default class ClientApi { | |||
| }, | |||
| { | |||
| applyDecorators: this._decorateStory, | |||
| getDecorators: () => [...localDecorators, ..._globalDecorators, withSubscriptionTracking], | |||
| getDecorators: () => [ | |||
| ...(allParam.decorators || []), | |||
There was a problem hiding this comment.
@tmeasday not part of the change per se, but why is this called allParam?
There was a problem hiding this comment.
@shilman I guess it's a combination of all parameters (local global etc) in a similar way?
There was a problem hiding this comment.
This is why I meant that addDecorator could just be redefined to addDecorator(d) => addParameters({ decorators: [d] })
shilman
approved these changes
Mar 1, 2019
|
🤷♀️
…On 1 Mar 2019, 4:42 PM +1100, Michael Shilman ***@***.***>, wrote:
@shilman commented on this pull request.
In lib/client-api/src/client_api.js:
> @@ -203,7 +203,12 @@ export default class ClientApi {
},
{
applyDecorators: this._decorateStory,
- getDecorators: () => [...localDecorators, ..._globalDecorators, withSubscriptionTracking],
+ getDecorators: () => [
+ ...(allParam.decorators || []),
@tmeasday not part of the change per se, but why is this called allParam?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
shilman
added
release
patch:done
shilman
added a commit
that referenced
this pull request
Mar 1, 2019
Allow local decorators via params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #5781
What I did
I added support for local decorators via a parameter. This doesn't resolve the issue but at least it provides a palatable alternative.