Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateNodeContainer should be consolidated / DRY'd up. #237

Closed
agouin opened this issue Aug 9, 2022 · 0 comments · Fixed by #447
Closed

CreateNodeContainer should be consolidated / DRY'd up. #237

agouin opened this issue Aug 9, 2022 · 0 comments · Fixed by #447
Labels
good first issue Good for newcomers

Comments

@agouin
Copy link
Member

agouin commented Aug 9, 2022

CreateNodeContainer is duplicative across the daemon containers in chain_node, tendermint_node, penumbra_app_node, relay_chain_node, and parachain_node.

Consider consolidating these into the internal docker package.
@agouin agouin mentioned this issue Aug 9, 2022
Merged
@jonathanpberger jonathanpberger added the good first issue Good for newcomers label Mar 17, 2023
@agouin agouin mentioned this issue Mar 18, 2023
Merged
@jonathanpberger jonathanpberger changed the title Consolidate CreateNodeContainer CreateNodeContainer should be consolidated / DRY'd up. Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consolidate create node container strangelove-ventures/interchaintest
2 participants
@jonathanpberger @agouin