Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for config.authenticator to be optional #36

Open
magom001 opened this issue Jul 11, 2020 · 0 comments
Open

Allow for config.authenticator to be optional #36

magom001 opened this issue Jul 11, 2020 · 0 comments

Comments

@magom001
Copy link

Currently AttestationChallengeBuilder.setAuthenticator throws an error if config.authenticator is not cross-platform or platform

This field is not mandatory. If not provided a browser prompt is presented (@see https://webauthn.io/).

I suggest to remove

const values = Object.values(Dictionaries.AuthenticatorAttachment)
if (!values.includes(authenticatorAttachment)) {
throw new Error(`Invalid AuthenticatorAttachment value. Must be one of "${values.join('", "')}".`)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant