-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StaticHeader::setup Improve error reporting #1443
Labels
sub-issue
issue that has a parent
Comments
6 tasks
5 tasks
Closing in favor of #2133, as that separates the action of reading and interpreting the signature buffers from the action of choosing and if necessary repairing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note: Taken from #1440 (comment)
This returns an error in two situations:
I think it is right to return an error in the first case, but I think the second should possibly be handled differently. I think a good option is to enrich the return type to
Additionally, taken from: #1440 (comment)
Actually, better to include both errors, and improve the error messages in the errors returned from
sigblock_from_buf
.The text was updated successfully, but these errors were encountered: