Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should look into retry packages in python #626

Closed
mulkieran opened this issue Jul 12, 2023 · 2 comments · Fixed by stratis-storage/stratisd#3620
Closed

We should look into retry packages in python #626

mulkieran opened this issue Jul 12, 2023 · 2 comments · Fixed by stratis-storage/stratisd#3620
Assignees
@mulkieran

Comments

@mulkieran
Copy link
Member

The retry crate in Rust has worked rather well, and there may be something just as good in the Python sphere. tenacity and retry are two candidate. We don't have to retry as much in Python production code as we do in Rust production code, but we do in test code.
@mulkieran mulkieran self-assigned this May 16, 2024
@mulkieran mulkieran mentioned this issue May 16, 2024
Merged
@mulkieran
Copy link
Member Author

Note that we would expect to use the retry package only in Python test code.

@mulkieran
Copy link
Member Author

When we use retry, we should consider waiting one cycle after the devices have been waited for in wait_for_udev. If the number of devices to be waited for is 0, and they need to come up, then wait_for_udev() may return, having waited not long enough for the devices it expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tenacity for retries in Python tests mulkieran/stratisd
1 participant
@mulkieran