refactor: 💡 create /vcssom folder and move some fn there

streamich · Mar 22, 2019 · aea14e5 · aea14e5
1 parent 857b2d2
commit aea14e5
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 57 deletions.
diff --git a/.storybook/vcssom/createUseCssDiffWithNano.ts b/.storybook/vcssom/createUseCssDiffWithNano.ts
@@ -1,4 +1,4 @@
-import {cssToTree} from '../../addon/vcssom';
+import {cssToTree} from '../../addon/vcssom/cssToTree';
 import {HookUseMemo} from './types';
 
 const createUseCssDiffWithNano = (nano: any) => (useMemo: HookUseMemo) => {

diff --git a/addon/vcssom.js b/addon/vcssom.js
@@ -1,60 +1,6 @@
 'use strict';
 
-var cssToTree = function (tree, css, selector, prelude) {
-    var declarations = {};
-    var hasDeclarations = false;
-    var key, value;
-
-    for (key in css) {
-        value = css[key];
-        if (typeof value !== 'object') {
-            hasDeclarations = true;
-            declarations[key] = value;
-        }
-    }
-
-    if (hasDeclarations) {
-        if (!tree[prelude]) tree[prelude] = {};
-        tree[prelude][selector] = declarations;
-    }
-
-    for (key in css) {
-        value = css[key];
-        if (typeof value === 'object') {
-            if (key[0] === '@') {
-                cssToTree(tree, value, selector, key);
-            } else {
-                var hasCurrentSymbol = key.indexOf('&') > -1;
-                var selectorParts = selector.split(',');
-                if (hasCurrentSymbol) {
-                    for (var i = 0; i < selectorParts.length; i++) {
-                        selectorParts[i] = key.replace(/&/g, selectorParts[i]);
-                    }
-                } else {
-                    for (var i = 0; i < selectorParts.length; i++) {
-                        selectorParts[i] = selectorParts[i] + ' ' + key;
-                    }
-                }
-                cssToTree(tree, value, selectorParts.join(','), prelude);
-            }
-        }
-    }
-};
-
-exports.cssToTree = cssToTree;
-
-function removeRule (sh, rule) {
-    var maxIndex = rule.index;
-    var rules = sh.cssRules || sh.rules;
-    maxIndex = Math.max(maxIndex, rules.length - 1);
-    while (maxIndex >= 0) {
-        if (rules[maxIndex] === rule) {
-            sh.deleteRule(maxIndex);
-            break;
-        }
-        maxIndex--;
-    }
-}
+var removeRule = require('./vcssom/removeRule').removeRule;
 
 exports.addon = function (renderer) {
     if (process.env.NODE_ENV !== 'production') {

diff --git a/addon/__tests__/vcssom.test.js → addon/vcssom/__tests__/cssToTree.test.js b/addon/__tests__/vcssom.test.js → addon/vcssom/__tests__/cssToTree.test.js
@@ -1,7 +1,7 @@
 /* eslint-disable */
 'use strict';
 
-var cssToTree = require('../vcssom').cssToTree;
+var cssToTree = require('../cssToTree').cssToTree;
 
 describe('cssToTree', function () {
     test('exist', function () {

diff --git a/addon/vcssom/cssToTree.js b/addon/vcssom/cssToTree.js
@@ -0,0 +1,42 @@
+function cssToTree (tree, css, selector, prelude) {
+    var declarations = {};
+    var hasDeclarations = false;
+    var key, value;
+
+    for (key in css) {
+        value = css[key];
+        if (typeof value !== 'object') {
+            hasDeclarations = true;
+            declarations[key] = value;
+        }
+    }
+
+    if (hasDeclarations) {
+        if (!tree[prelude]) tree[prelude] = {};
+        tree[prelude][selector] = declarations;
+    }
+
+    for (key in css) {
+        value = css[key];
+        if (typeof value === 'object') {
+            if (key[0] === '@') {
+                cssToTree(tree, value, selector, key);
+            } else {
+                var hasCurrentSymbol = key.indexOf('&') > -1;
+                var selectorParts = selector.split(',');
+                if (hasCurrentSymbol) {
+                    for (var i = 0; i < selectorParts.length; i++) {
+                        selectorParts[i] = key.replace(/&/g, selectorParts[i]);
+                    }
+                } else {
+                    for (var i = 0; i < selectorParts.length; i++) {
+                        selectorParts[i] = selectorParts[i] + ' ' + key;
+                    }
+                }
+                cssToTree(tree, value, selectorParts.join(','), prelude);
+            }
+        }
+    }
+};
+
+exports.cssToTree = cssToTree;
diff --git a/addon/vcssom/removeRule.js b/addon/vcssom/removeRule.js
@@ -0,0 +1,14 @@
+function removeRule (sh, rule) {
+    var maxIndex = rule.index;
+    var rules = sh.cssRules || sh.rules;
+    maxIndex = Math.max(maxIndex, rules.length - 1);
+    while (maxIndex >= 0) {
+        if (rules[maxIndex] === rule) {
+            sh.deleteRule(maxIndex);
+            break;
+        }
+        maxIndex--;
+    }
+}
+
+exports.removeRule = removeRule;