Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0 broke sheet() using extract #189

Closed
TheBosZ opened this issue Jul 16, 2018 · 7 comments
Closed

v3.0.0 broke sheet() using extract #189

TheBosZ opened this issue Jul 16, 2018 · 7 comments

Comments

@TheBosZ
Copy link
Contributor

TheBosZ commented Jul 16, 2018

I can't figure out exactly why, but v3.0.0 broke my plugin: https://bitbucket.org/TheBosZ/rollup-plugin-nano-css/

With 2.2.0, all tests pass, but with 3.0.0, calling nano.sheet returns an empty object instead of the expected string of class names.
@streamich
Copy link
Owner

I need some code to replicate that behaviour, to be able to fix that.

@TheBosZ
Copy link
Contributor Author

TheBosZ commented Jul 16, 2018

Sorry, the tests on that project replicate it but I can pull them out into an example if you'd like.

@TheBosZ
Copy link
Contributor Author

TheBosZ commented Jul 16, 2018

It looks like the extract addon is no longer forcing the lazy load of sheet.

@TheBosZ
Copy link
Contributor Author

TheBosZ commented Jul 16, 2018

This repo can show the issue: https://github.com/TheBosZ/nano-css-problems/

Run: npm i && npm run extract

The sheet has the button property, but the resulting object no longer has the property.

In 2.2.0, the object returned from sheet() was already loaded. Now it's back to being lazy-loaded.

@streamich
Copy link
Owner

This #190 should fix your problem.

streamich pushed a commit that referenced this issue Jul 16, 2018
@semantic-release-bot
chore(release): 3.0.1 [skip ci]
7da8fc9 
## [3.0.1](v3.0.0...v3.0.1) (2018-07-16)

### Bug Fixes

* 🐛 enumerate map returned by sheet() ([58da52a](58da52a)), closes [#189](#189)
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TheBosZ
Copy link
Contributor Author

TheBosZ commented Jul 16, 2018

Perfect! 3.0.1 solves the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBosZ @streamich