Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It does not detect livestreamer in mac #55

Closed
craked5 opened this issue Mar 7, 2015 · 19 comments
Closed

It does not detect livestreamer in mac #55

craked5 opened this issue Mar 7, 2015 · 19 comments

Comments

@craked5
Copy link

craked5 commented Mar 7, 2015

Hey! First let me say thanks for doing this awesome program!
I installed it on my mac and when i try to watch a stream it tells me that it cannot detect a Livestreamer installation. Livestreamer is certainly installed and on the $path variable also.

Thanks for the help in advance, awesome job!

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

I got it! Thanks anyway mate!

@craked5 craked5 closed this as completed Mar 7, 2015
@bastimeyer
Copy link
Member

Hi, thanks!
Did you set the livestreamer location manually in the settings or how did you solve the issue?
This actually was an old issue which was fixed by #24... On OSX, certain apps don't have access to some env variables (including $PATH). The fix was to set $PATH inside the Info.plist file with default paths.
https://github.com/bastimeyer/livestreamer-twitch-gui/blob/cdb856eab4c913238f0a50a793200ecb742cb55f/build/tasks/configs/nodewebkit.js#L11-L13
So I'd like to know if there actually is another issue...

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

Hey! I did set the livestreamer location manually or else it wouldnt find livestreamer!
Thanks!

@craked5 craked5 reopened this Mar 7, 2015
@bastimeyer
Copy link
Member

Could you please start the application with the --remote-debugging-port=8888 parameter and open http://localhost:8888 in your browser? What I'm looking for is the value of process.env.PATH from the dev console.
Also, you're using the latest version, right?

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

Yep, using the latest version!
The process.env.PATH returns this: "/usr/bin:/bin:/usr/sbin:/sbin"

@bastimeyer
Copy link
Member

Please check if you find the following inside the livestreamer-twitch-gui.app/Contents/Info.plist file:

    <key>LSEnvironment</key>
    <dict>
      <key>PATH</key>
      <string>/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin</string>
    </dict>

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

Yep its exactly like that! I checked that earlier when i read the issue #24
Should i do something anywhere else?

@bastimeyer
Copy link
Member

tbh, I don't know what to do from this point on... I personally don't use OSX, so I have no idea why this is failing. The Info.plist file should also be fine. Last time I've checked this in my VM, it was all working correctly... Which OSX version are you using? How do you start the application?

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

Well its fine by me mate, i can just do it manually!
I have the latest version, 10.10.2.
I started in the terminal with: open /Applications/Livestreamer\ Twitch\ GUI.app --args --remote-debugging-port=8888
Normally i just click the app.

Thanks for the help dude :)

@bastimeyer
Copy link
Member

The thing is that I don't know if it's still an issue with the osx builds or if this just happens on your machine. But ok, can't do anything right now... 😩

@craked5
Copy link
Author

craked5 commented Mar 7, 2015

Ye that sucks, an idea would be to put the manual path as default. I dont know if it would work.

@Wraul
Copy link
Contributor

Wraul commented Mar 7, 2015

It appears that in OS X 10.10 the PATH environment variable isn't possible to set with LSEnvironment in Info.plist.
Other environment variables works just fine though.

If this is intentional or a bug I don't know.

@bastimeyer
Copy link
Member

Ye that sucks, an idea would be to put the manual path as default. I dont know if it would work.

Yep, that's the only solution that I can come up with, too. Although I must say, that I hate it to build in those kind of exceptions into the application code itself.

It appears that in OS X 10.10 the PATH environment variable isn't possible to set with LSEnvironment in Info.plist.
Other environment variables works just fine though.

If this is intentional or a bug I don't know.

Oh apple, you **** 😡

@bastimeyer
Copy link
Member

@craked5
Would you please be so kind and test my fix 1870260? Thanks!!!

git clone -b osx-livestreamer-fallback-fix https://github.com/bastimeyer/livestreamer-twitch-gui.git
cd livestreamer-twitch-gui
sudo npm install grunt-cli bower
npm install
grunt release && open build/releases/livestreamer-twitch-gui/osx64/livestreamer-twitch-gui.app

@SkylerLipthay
Copy link

@bastimeyer I'm running on Mac OS X 10.10.2 and I can confirm 1870260 fixes this problem!

@bastimeyer
Copy link
Member

ty, @SkylerLipthay

@craked5
Copy link
Author

craked5 commented Mar 11, 2015

Hey dude sorry for not saying anything soon, but my 2010 mac just died for good i think!
Well i am relieved to see that its fixed! Thanks for the help dude, take care :)

@bastimeyer
Copy link
Member

np, I'm glad this nasty bug is finally fixed

@bastimeyer
Copy link
Member

v0.7.2 released...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants