Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to reset settings in the app itself #865

Open
4 tasks done
fracture93 opened this issue Feb 4, 2022 · 2 comments
Open
4 tasks done

Ability to reset settings in the app itself #865

fracture93 opened this issue Feb 4, 2022 · 2 comments

Comments

@fracture93
Copy link

fracture93 commented Feb 4, 2022

Checklist

Description

Hello,

For some reason my settings corrupt every few months, I am not sure what is causing it but it ends up meaning I cannot get streams to launch at all until I go into my appdata and delete the streamlink twitch gui config in there. As I cannot figure out what is causing my corrupted settings I did not want to submit a bug report on it, instead I was wondering if there is any way you could add a way to delete the settings in twitch gui itself. It is a relatively simple thing to go to the appdata folder and delete there but I also know I am more willing to dig into these issues than others. This could also be a good idea for those who just want to reset their settings to default.

  • What is it?
    Ability to reset settings in the app itself
  • How would you expect it to work?
    An option in the settings menu
  • What value does it bring to Streamlink Twitch GUI?
    Allow those who want to reset settings to do so without digging through the appdata folder
  • Is it supported by the Twitch API?
    I believe this would not require the twitch API at all
  • Does it fit into the scope and aims of the project?
    I guess that would be up to you to decide, I do not think it goes against the aims of the project at all personally.

Thanks for taking time to read this, and I appreciate your running this project. It has been tremendously helpful for my enjoyment of twitch.

@bastimeyer
Copy link
Member

Ability to reset settings in the app itself

That would be fairly simple by wiping the app's entire localStorage and reloading the page, so everything gets re-initialized. Something like this should never be necessary though, so I don't know if I want to implement this.

A regular settings wipe that just resets the settings to their initial state could also be done, but I remember having commented somewhere here on the issue tracker in the past that the settings are so simple that it's not really worth it implementing this and I pretty much still have the same opinion.

I'll think about it...

my settings corrupt every few months
meaning I cannot get streams to launch at all

This sounds more like a Streamlink error than a Streamlink Twitch GUI error. Without a proper description though, I can't give an answer here.

Are you using lots of channel specific settings by any chance? It is unlikely that the regular application settings themselves are causing issues, as it's simple JSON data that gets mapped onto a single EmberData model with a couple of model-fragments, and it's just a single data record that gets managed by the SettingsService. This is all tested.

I have never heard about this happening to any other user before. If this should happen to you again, please run a development or debug build (see the project's readme) and recover the data from the application's localStorage. The Twitch GUI can be started with --remote-debugging-port=8888 when running a development or debug build so that http://localhost:8888 can be opened for being able to access the app's development tools, regardless whether the app has successfully loaded or not. Then the localStorage can be accessed via the the "Application" tab or by running window.localStorage in the "Console" tab.

@fracture93
Copy link
Author

Are you using lots of channel specific settings by any chance? It is unlikely that the regular application settings themselves are causing issues, as it's simple JSON data that gets mapped onto a single EmberData model with a couple of model-fragments, and it's just a single data record that gets managed by the SettingsService. This is all tested.

Negative on the channel specific settings issue, I actually barely change any settings only enabling ad skipping and changing it so VLC player is the default player so it can show the stream title in the title bar. I will try and get more data for the settings corrupting in the future when it happens again, I believe it is not streamlink itself corrupting because I can resolve it just by deleting streamlink twitch gui settings in appdata and leaving streamlink settings alone.

Thanks for the response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants