Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of ad breaks #933

Open
4 tasks done
bastimeyer opened this issue Nov 17, 2022 · 1 comment
Open
4 tasks done

Improve display of ad breaks #933

bastimeyer opened this issue Nov 17, 2022 · 1 comment

Comments

@bastimeyer
Copy link
Member

Checklist

Description

Opening this as a reminder for myself to improve the display of the stream status during an ad break.

Streamlink prints messages to its log output whenever an ad break occurs, for both pre-roll and mid-roll ads. Streamlink Twitch GUI should show this status in the title of the stream popup or on the watching page whenever ads are being filtered out.

Previously, Streamlink Twitch GUI also delayed the "watching" status until pre-roll ads were finished, but something must have broken recently, and now it's showing the "watching" status even though pre-roll ads are still running.

I should probably also move the ads filtering option a little bit, as it's kinda hidden in the settings menu.

@bastimeyer
Copy link
Member Author

I should probably lock this thread, and reference the stickied meta thread.

Please read this and all the linked threads / docs:
#754

@streamlink streamlink locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant