Predefined player parameters #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
player-configs
branch
2 times, most recently
from
885e153
to
2536b83
Compare
- Reformat player attribute in the settings model - Remove player_params attribute (merged with player) - Add player update logic to initializers/localstorage - Add models/LivestreamerPlayerParameters - Refactor Livestreamer.getParameters and update LivestreamerParameters - Refactor LivestreamerService - Add preset/param selection to player settings menu - Remove advanced settings restriction from custom player parameters
bastimeyer
force-pushed
the
player-configs
branch
from
2536b83
to
6a1de1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a list of known players and parameters, so that users don't need to specify these by themself and certain player behaviors can be forced. Most of the users will never set player parameters and some will use them incorrectly. Having a list of known parameters and a default configuration for each player will solve multiple issues.
Use these as a fallback and let the user set custom paths.
Player behavior, player window title, buffering/caching, etc.
Tell users about each parameter and give them control over each one.
In addition to (as a replacement of) the enabled parameters.
Players