You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Now, don‘t register logical type conversions when use SchemaDefinition.<T>builder().withJsonDef() to create the schema, beacase it without classLoader param. (e.g: apache#15899)
We can add the classLoader field for SchemaDefinition, user can manually pass a classLoader to register logical type conversions
Goal
This proposes to add the classLoader field for SchemaDefinition. When using SchemaDefinition.<T>builder().withJsonDef() to create the schema it must manually specify a classLoader otherwise, the converter will not work.
The priority of the classLoader field will be higher than by the pojoClass.getClassLoader().
Original Issue: apache#16058
Motivation
Now, don‘t register logical type conversions when use
SchemaDefinition.<T>builder().withJsonDef()
to create the schema, beacase it without classLoader param. (e.g: apache#15899)See: https://github.com/apache/pulsar/blob/04aa9e8e51869d1621a7e25402a656084eebfc09/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java#L58-L68
We can add the classLoader field for SchemaDefinition, user can manually pass a classLoader to register logical type conversions
Goal
This proposes to add the classLoader field for SchemaDefinition. When using
SchemaDefinition.<T>builder().withJsonDef()
to create the schema it must manually specify a classLoader otherwise, the converter will not work.The priority of the classLoader field will be higher than by the
pojoClass.getClassLoader()
.API Changes
Implementation
Add the classloader field for SchemaDefinition.
The text was updated successfully, but these errors were encountered: