Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monorail bridges to maxheight quest #4387

Closed
Squamoto opened this issue Sep 18, 2022 · 4 comments · Fixed by #4393
Closed

Add monorail bridges to maxheight quest #4387

Squamoto opened this issue Sep 18, 2022 · 4 comments · Fixed by #4393

Comments

@Squamoto
Copy link

Use case
Currently the maxheight quest only checks for crossing railway bridges with these attributes:
rail|light_rail|subway|narrow_gauge|tram|disused|preserved|funicular

Monorail bridges should be included too. Real life use case:

https://www.openstreetmap.org/note/3360680

Proposed Solution
Add monorail in AddMaxHeight.kt#L47

@Squamoto Squamoto changed the title Add monorail to maxheight quest Add monorail bridges to maxheight quest Sep 18, 2022
@westnordost
Copy link
Member

Sure, will you create a PR?

@adbok001
Copy link

Easier if you just add it yourself I guess

@westnordost
Copy link
Member

The reason why I encourage users to make simple changes deemed useful themselves is because my own time is limited and there are certain things in this project only I or very few other experienced contributors can do which is why I try to focus on these.
Furthermore, by changing it oneself, new contributors may become slowly more familiar with the code and be able to do more complex things later on, making the number of people that maintain this project larger, ensuring the future of this project.

One reason why I started this project at all was because I eventually realized that most OSM enthusiasts are not software developers and while I could just merrily map on, I'd have a greater impact if I created software that made it more easy for others to contribute - because fewer are able to do that as they are not software developers.
Everyone can help according to his/her own ability. I believe adding monorail to that quest filter is well within your ability to contribute.

@mcliquid
Copy link
Contributor

Since I have just anyway the project open, I have taken over here without further ado. Will be fixed with PR #4393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants