Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify where files should be stored. #1698

Merged
merged 1 commit into from
Dec 8, 2022
Merged

chore: clarify where files should be stored. #1698

merged 1 commit into from
Dec 8, 2022

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Dec 8, 2022

Description

Clarify that dictionary/*/dict files are generated and should not be edited.

@Jason3S Jason3S merged commit 6567bc6 into main Dec 8, 2022
@Jason3S Jason3S deleted the dev-dict branch December 8, 2022 14:05
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
@nschonni
Copy link
Collaborator

nschonni commented Dec 8, 2022

Does it make sense to add these to the .gitignore and then use a force add for the parts that do the generation?

@Jason3S
Copy link
Collaborator Author

Jason3S commented Dec 12, 2022

@nschonni,

I decided to keep a copy of the compiled dictionaries in dict. This is to help catch issues with tool changes that make changes to how dictionaries are compiled. The files tend to be small compared to the Natural language dictionaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants