Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Convert et-EE license to LGPL 3.0 #2624

Merged

Conversation

calvinballing
Copy link
Collaborator

@calvinballing calvinballing commented Oct 7, 2023

Fix Dictionary

Dictionary: et-EE

Description

Convert et-EE license to LGPL 3.0

References

The et-EE dictionary used is the one found at this link. That dictionary is released with the following license statement (translated to English via Google Translate):
"The dictionary files on this page themselves are distributed under the GNU Lesser General Public License"

Checklist

  • By submitting this issue, you agree to follow our
    Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

@calvinballing calvinballing force-pushed the convert-et-EE-license-to-lgpl branch from 3d53ea4 to d0b2c37 Compare October 7, 2023 20:31
@calvinballing
Copy link
Collaborator Author

Does this need a version bump for the library because the license is changing? I thought that might be appropriate when the license changes, but I didn't see it happen for the Polish library when it had a license change here: https://github.com/streetsidesoftware/cspell-dicts/pull/2340/files

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 8, 2023

Does this need a version bump for the library because the license is changing? I thought that might be appropriate when the license changes, but I didn't see it happen for the Polish library when it had a license change here: https://github.com/streetsidesoftware/cspell-dicts/pull/2340/files

Yes, this is a major version change. The package.json version is updated automatically in the release process.

@Jason3S Jason3S merged commit ca1974b into streetsidesoftware:main Oct 8, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
@Jason3S
Copy link
Collaborator

Jason3S commented Oct 8, 2023

See: #2625

@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants