fix: Add software terms from #1430 #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason3S
reviewed
Oct 10, 2023
| @@ -1434,6 +1460,18 @@ process | |||
| processed | |||
| processes | |||
| procfs | |||
| productisation | |||
| productisations | |||
| productise | |||
There was a problem hiding this comment.
Both productize and productise are considered valid British English spellings of the same word. But only productize is considered valid in US English.
Since productise is already in the en-GB, I don't think we need to add it here.
|
fyi: Wiktionary is not a 100% reliable source. Many of the words were programmatically added. |
calvinballing
force-pushed
the
add-terms-from-1430
branch
from
21505bb to
71c97ca
Compare
calvinballing
force-pushed
the
add-terms-from-1430
branch
from
71c97ca to
43da98f
Compare
Let me know if this implies that you'd like any further changes on this PR |
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to softwareTerms Dictionary
Dictionary: softwareTerms
Description
Adds
deparameterize,productize,unimported,deauthentication,onboard, and their variations, along with variant spellings.References
Checklist
Code of Conduct
fix:- for minor changes like adding words or fixing spelling issues.feat:- for a significant change like adding a whole new set of words to a dictionary.feat!:- for breaking changes, like file format or licensing changes.chore:- for changes that do not impact the content of dictionaries.