feat: Custom reporters support #1643
Conversation
|
Cool. I'll take a look at it. |
|
I'm impressed. You put a lot of work into it. I like the idea of having multiple reporters. Then it can work with custom loggers. |
|
Thank you for all the effort! |
|
Thanks for CR, I'll try to fix the issues this week. What do you think of additional testing? Do I need to add any unit tests before this can be merged? |
It took a lot of effort to get the code coverage as high as it is. I would like to keep it that way. If you want some help with tests, I can help out by breaking out some of the independent stuff and getting it landed. |
mad-gooze
force-pushed
the
customizable-reporters
branch
from
873c9ec
to
9607d70
Compare
packages/cspell-json-reporter/src/utils/validateSettings.test.ts
Outdated
Show resolved
Hide resolved
mad-gooze
force-pushed
the
customizable-reporters
branch
from
f7c73cf
to
cc431d3
Compare
packages/cspell-json-reporter/src/__snapshots__/index.test.ts.snap
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "issues": [ | |||
There was a problem hiding this comment.
Is this a sample file? Or a result of running a test?
There was a problem hiding this comment.
this a result of running example, I've forgotten to put in in gitignore
There was a problem hiding this comment.
Ahh, it is best to write it into temp, some of the other packages do the same thing.
|
I think it's complete? |
|
Great! I'll land it. |
Hi Jason!
This PR proposes custom reporters support which allows implementing things like #21 in the future.
It definitly needs better documentation and tests, could you review it and discuss if you find the way I implemented is ok?