Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cspell-glob matches only files under the root #913

Merged
merged 3 commits into from
Feb 3, 2021
Merged

feat: cspell-glob matches only files under the root #913

merged 3 commits into from
Feb 3, 2021

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Feb 3, 2021

For historical reasons, cspell-glob assumed two roots:

  1. the one passed in which defaulted to the current working directory
  2. the FS root on any drive.

This happened because it was sometimes difficult to determine the root inside the VS Code extension.

In cspell 5, there is a shift with the ignorePaths meaning to be relative to the location of the file that defined them.

It will also be possible to define the root for the ignorePaths within the configuration file.

@Jason3S Jason3S merged commit a2d700d into master Feb 3, 2021
@Jason3S Jason3S deleted the dev branch February 3, 2021 07:10
timwsuqld referenced this pull request Mar 2, 2021
Try to support the "assumed" behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant