Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2022-28948 - Remove gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c #1532

Closed
vmatyus opened this issue Feb 13, 2024 · 3 comments
Closed

Comments

@vmatyus
Copy link

vmatyus commented Feb 13, 2024

Github Advisor reported a vulnerable package: gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
Here is the CVE report.

One of my application usestestify package as dependency, in the current setup my application is vulnerable, this is why I am asking from you to correct this vulnerability.

I checked the dependency usage in the following way:

go mod graph | grep "gopkg.in/yaml.v3@v3.0.0-20200313102051-9f266ea9e77c"
github.com/stretchr/testify@v1.7.1 gopkg.in/yaml.v3@v3.0.0-20200313102051-9f266ea9e77c

go mod graph | grep "github.com/stretchr/testify@v1.7.1"                 
github.com/stretchr/objx@v0.4.0 github.com/stretchr/testify@v1.7.1

go mod graph | grep "github.com/stretchr/objx@v0.4.0"   
github.com/stretchr/testify@v1.8.0 github.com/stretchr/objx@v0.4.0

go mod graph | grep "github.com/stretchr/testify@v1.8.0"
github.com/stretchr/objx@v0.5.0 github.com/stretchr/testify@v1.8.0

go mod graph | grep "github.com/stretchr/objx@v0.5.0"   
github.com/stretchr/testify@v1.8.4 github.com/stretchr/objx@v0.5.0

go mod graph | grep "github.com/stretchr/testify@v1.8.4"
github.ibm.com/cloudant/rc-sync github.com/stretchr/testify@v1.8.4
github.com/stretchr/testify@v1.8.4 github.com/davecgh/go-spew@v1.1.1
github.com/stretchr/testify@v1.8.4 github.com/pmezard/go-difflib@v1.0.0
github.com/stretchr/testify@v1.8.4 github.com/stretchr/objx@v0.5.0
github.com/stretchr/testify@v1.8.4 gopkg.in/yaml.v3@v3.0.1
github.ibm.com/IAM/context-token@v0.2.3 github.com/stretchr/testify@v1.8.4
github.ibm.com/IAM/pep/v4@v4.2.1-release github.com/stretchr/testify@v1.8.4
github.ibm.com/IAM/token/v5@v5.2.5 github.com/stretchr/testify@v1.8.4

From the above dependency tree can be seen that the vulnerable package is pulled in through github.com/stretchr/objx@v0.5.0.

I would like to ask from you to correct this package vulnerability.

@vmatyus
Copy link
Author

vmatyus commented Feb 13, 2024

Reported the issue to github.com/stretchr/objx: stretchr/objx#146

@brackendawson
Copy link
Collaborator

v1.8.4 does not have this vulnerability:

gopkg.in/yaml.v3 v3.0.1

It is not a problem if vulnerable modules appear in your graph. The vulnerable yaml module will not be built into any of your binaries using testify >= 1.8.4.

@brackendawson brackendawson closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@vmatyus
Copy link
Author

vmatyus commented Feb 29, 2024

I could not really differentiate what is compiled into the binaries and what is not.
The go.mod and go.sum file contains packages that needed for production and test environment.
This way I would like to ask from you to integrate this solution: stretchr/objx#146 (comment) - after it reaches the publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants