Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected nil, but got: (unsafe.Pointer)(nil) #863

Closed
eloff opened this issue Jan 3, 2020 · 2 comments
Closed

Expected nil, but got: (unsafe.Pointer)(nil) #863

eloff opened this issue Jan 3, 2020 · 2 comments
Labels
assert.IsNil About assert.IsNil/IsNotNil bug pkg-assert Change related to package testify/assert
Projects
Roadmap
Milestone
v2.0.0

Comments

@eloff
Copy link

eloff commented Jan 3, 2020

Nil/NotNil assertions should work with unsafe.Pointer, since == nil and != nil do.
@boyan-soubachov
Copy link
Collaborator

Thanks for this @eloff , it's a good point. I'd be happy to look into this or if you'd like, submit a PR which I'd be very glad to review and merge :)

@boyan-soubachov boyan-soubachov added this to the Next Release milestone Jan 7, 2020
@boyan-soubachov boyan-soubachov mentioned this issue Jan 24, 2020
Closed
@boyan-soubachov boyan-soubachov modified the milestones: Next, Next + 1 Feb 18, 2020
@mvdkleijn mvdkleijn added this to Evaluate / Should it be done? in Roadmap via automation Aug 12, 2020
@mvdkleijn mvdkleijn moved this from Evaluate / Should it be done? to In progress in Roadmap Aug 12, 2020
@dolmen
Copy link
Collaborator

dolmen commented Nov 8, 2023

Fixed by #1319.

@dolmen dolmen added bug pkg-assert Change related to package testify/assert assert.IsNil About assert.IsNil/IsNotNil labels Nov 8, 2023
@dolmen dolmen closed this as completed Nov 8, 2023
Roadmap automation moved this from In progress to Not accepted or Done Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert.IsNil About assert.IsNil/IsNotNil bug pkg-assert Change related to package testify/assert
Projects
Roadmap
  
Not accepted or Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Add unsafe.Pointer to Nil/NotNil checks boyan-soubachov/testify
3 participants
@eloff @dolmen @boyan-soubachov