From c740480fc1a1692280f2f62cc20af82777301030 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Mengu=C3=A9?= Date: Sun, 30 Jul 2023 20:51:12 +0200 Subject: [PATCH] mock: refactor TestIsArgsEqual Refactor tests to use 'append' to build copies of slices instead of manual loops. Thanks golangci-lint. --- mock/mock_test.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mock/mock_test.go b/mock/mock_test.go index 77493c55d..52d20bed5 100644 --- a/mock/mock_test.go +++ b/mock/mock_test.go @@ -1616,17 +1616,14 @@ func Test_Mock_IsMethodCallable(t *testing.T) { func TestIsArgsEqual(t *testing.T) { var expected = Arguments{5, 3, 4, 6, 7, 2} - var args = make([]interface{}, 5) - for i := 1; i < len(expected); i++ { - args[i-1] = expected[i] - } + + // Copy elements 1 to 5 + args := append(([]interface{})(nil), expected[1:]...) args[2] = expected[1] assert.False(t, isArgsEqual(expected, args)) - var arr = make([]interface{}, 6) - for i := 0; i < len(expected); i++ { - arr[i] = expected[i] - } + // Clone + arr := append(([]interface{})(nil), expected...) assert.True(t, isArgsEqual(expected, arr)) }