-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OutlinedBox #2958
Comments
@leandrofavarin thanks for filing. We'll add this to our backlog. |
Thanks Michael! |
Hi @mshafrir-stripe, is there any update or any workaround while we're waiting for an "official" way of supporting this? Maybe by overriding a layout? It doesn't seem to work with a FilledBox also. I found an issue and a related PR which should have addressed this issue but it does not work either:
I also tested by adding this to my app's styles (code is reduced to the minimum): <?xml version="1.0" encoding="utf-8"?>
<resources xmlns:android="http://schemas.android.com/apk/res/android">
<style name="AppTheme" parent="AppThemeBase">
<item name="textInputStyle">@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox</item>
</style>
</resources> It has no effect either. Also, it would be very convenient to have a "how to theme widgets" guide in the docs (with at least one example). Thanks for your help on this! |
Hi Stripe, any update on this in 7 months? |
@sebj54 Sorry for the delay just looking to see if I have an alternative |
Hi @michelleb-stripe, thanks for catching up! I don't know if it can be useful, but here's the better I can get with CardMultilineWidget's style: triniwiz/nativescript-plugins#83 (comment) |
@sebj54 Based on that comment looks like you were able to do a lot of the style, but still were unable to make it an OutlineBox. Is that correct? |
Exactly! If I use an OutlineBox in the XML layout file, it throws an error. If I remember well, it is because OutlineBox does not implement everything the Stripe view is using (I don't remember if it's the Layout or the EditText). |
@sebj54 Thanks for that clarification. We have some work in our backlog to work on our overall widget styling strategy. |
Great! Can't wait to try it 😃 |
Summary
Can't use the Material
OutlinedBox
variant of theTextInputLayout
Code to reproduce
Android version
Q
Impacted devices
n/A
Installation method
n/A
SDK version
16.0.1
Other information
Also tried using the
Stripe.CardInputWidget.TextInputLayout
, as well as without theTextInputLayout
wrapping theCardInputWidget
.Currently it looks like this:
The text was updated successfully, but these errors were encountered: