Merge pull request #703 from stripe/ob-java-12

Start testing Java 12
stripe · Jul 8, 2019 · e1c46fb · e1c46fb
2 parents 789303f + 1b556f8
commit e1c46fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -26,6 +26,7 @@ matrix:
     - jdk: openjdk9
     - jdk: openjdk10
     - jdk: openjdk11
+    - jdk: openjdk12
     - jdk: openjdk-ea
   allow_failures:
     - jdk: openjdk-ea

diff --git a/build.gradle b/build.gradle
@@ -29,6 +29,13 @@ version = VERSION_NAME
 tasks.withType(JavaCompile) {
     options.compilerArgs << "-Xlint:all" << "-Xlint:-options" << "-Xlint:-processing"
     options.encoding = 'UTF-8'
+
+    options.errorprone {
+      // This check is broken in Java 12.  See https://github.com/google/error-prone/issues/1257
+      if ((JavaVersion.current().majorVersion as Integer) > 11) {
+        check('Finally', net.ltgt.gradle.errorprone.CheckSeverity.OFF)
+      }
+    }
 }
 
 compileJava {