Start testing Java 12 #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Travis doesn't support Java 12 yet. I'll keep this open for now. |
ob-stripe
force-pushed
the
integration-v9
branch
2 times, most recently
from
03ccc63 to
03e6e0a
Compare
ob-stripe
force-pushed
the
integration-v9
branch
2 times, most recently
from
8fb1316 to
4d642f5
Compare
|
It looks like Lombok doesn't yet support Java 12. Travis doesn't seem to support OracleJDK 12, but with OpenJDK 12 we're running into this error: projectlombok/lombok#2082. |
mickjermsurawong-stripe
force-pushed
the
integration-v9
branch
from
32d1cab to
a9b605f
Compare
|
Okay, so the Lombok issue was fixed in 1.18.8, but there is another issue with Error Prone: google/error-prone#1257. They already have a fix for it: google/error-prone#1107, but it's not merged yet. Once it's released, hopefully we can start testing Java 12 for real 🤞 |
|
Wow, not an easy road getting this turned on :) LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Start testing Java 12.
I had to disable a specific ErrorProne check with Java 12 because of an issue with ErrorProne itself (cf. #703 (comment)). Once they fix the issue, we can re-enable the check.