build: remove ts-node dev-dependency #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A high-level summary of the changes:
TODO: figure out how to tell |
bajtos
changed the title
bajtos
force-pushed
the
build/remove-tsnode
branch
from
2ac9a00
to
519a815
Compare
bajtos
changed the title
Done in 519a815. This pull request is ready for final review and landing. @raymondfeng @kjdelisle @virkt25 PTAL. |
raymondfeng
approved these changes
Oct 4, 2017
virkt25
approved these changes
Oct 4, 2017
Refactor project infrastructure to transpile test files together with production code and then run the tests from plain javascript code. Benefits: - consistent error message parseable by VSCode's $tsc problem matcher (compiler errors from test files will show in Problems window now) - earlier feedback about type-related problems in test files, no need to wait for ts-node to load type information from tsc output - slightly faster red-green-refactor cycle, `npm test` takes 27s instead of 32s. - we are opening doors to eventually start using `tsc --watch` once TypeScript adds support for multi-project repositories, see microsoft/TypeScript#3469
bajtos
force-pushed
the
build/remove-tsnode
branch
from
61292af
to
0b49bad
Compare
bajtos
added a commit
that referenced
this pull request
Jan 22, 2018
When we got rid of ts-node in #602, we also unintentionally dropped the code modifying error stack traces to point to original TypeScript sources instead of the transpiled JavaScript output. As a result, assertion failures contained stack traces pointing to code that we are not familiar with, which made troubleshooing difficult. This commits add source-map-support as a dependency of our projects and modifies shared `mocha.opts` to register it at runtime.
6 tasks
bajtos
added a commit
that referenced
this pull request
Jan 23, 2018
When we got rid of ts-node in #602, we also unintentionally dropped the code modifying error stack traces to point to original TypeScript sources instead of the transpiled JavaScript output. As a result, assertion failures contained stack traces pointing to code that we are not familiar with, which made troubleshooing difficult. This commits add source-map-support as a dependency of our projects and modifies shared `mocha.opts` to register it at runtime.
bajtos
added a commit
that referenced
this pull request
Jan 25, 2018
When we got rid of ts-node in #602, we also unintentionally dropped the code modifying error stack traces to point to original TypeScript sources instead of the transpiled JavaScript output. As a result, assertion failures contained stack traces pointing to code that we are not familiar with, which made troubleshooing difficult. This commits add source-map-support as a global dev-dependency plus a dev-dependency of example repositories that must work outside of our monorepo too. The single shared `mocha.opts` was split into two different options files: - `mocha.ts.opts` which registers source-map support - `mocha.js.opts` with no support for source maps
bajtos
added a commit
that referenced
this pull request
Jan 25, 2018
When we got rid of ts-node in #602, we also unintentionally dropped the code modifying error stack traces to point to original TypeScript sources instead of the transpiled JavaScript output. As a result, assertion failures contained stack traces pointing to code that we are not familiar with, which made troubleshooing difficult. This commits add source-map-support as a global dev-dependency plus a dev-dependency of example repositories that must work outside of our monorepo too. The single shared `mocha.opts` was split into two different options files: - `mocha.ts.opts` which registers source-map support - `mocha.js.opts` with no support for source maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor project infrastructure to transpile test files together with production code and then run the tests from plain javascript code.
Benefits:
consistent error message parseable by VSCode's $tsc problem matcher
(compiler errors from test files will show in Problems window now)
earlier feedback about type-related problems in test files,
no need to wait for ts-node to load type information from
tsc output
slightly faster red-green-refactor cycle,
npm testtakes 27s instead of 32s.we are opening doors to eventually start using
tsc --watchonce TypeScript adds support for multi-project repositories,
see Support "medium-sized" projects microsoft/TypeScript#3469