Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline field validation message? #49

Closed
kctang opened this issue May 30, 2016 · 5 comments
Closed

Support for inline field validation message? #49

kctang opened this issue May 30, 2016 · 5 comments
Assignees
Milestone

Comments

@kctang
Copy link

kctang commented May 30, 2016

Customizing a theme based on this package...progress is good but can't seem to get the form error messages to show next to input fields.

I am using MDL. It looks something like:

  <div class="mdl-textfield mdl-js-textfield">
    <input class="mdl-textfield__input" type="text" id="sample2">
    <label class="mdl-textfield__label" for="sample2">Number...</label>
    <!-- render this on error -->
    <span class="mdl-textfield__error">Input is not a number!</span>
  </div>

Any hints on how this can be done or is this a feature request?

@timbrandin
Copy link
Member

Great suggestion, have myself thought about adding this. Though my time is limited, so this would likely take some time before I can look into, if you find the time to write a PR, I'd be happy to review and merge it!

@kctang
Copy link
Author

kctang commented May 31, 2016

Ok good to know that you have this in mind. As much as I would love to, I don't think I can provide a PR anytime soon. I'll take a look after my current project is done if others didn't get to it first.

Thanks!

@timbrandin timbrandin added this to the 1.3 milestone Dec 18, 2016
@timbrandin timbrandin self-assigned this Dec 18, 2016
@timbrandin
Copy link
Member

timbrandin commented Dec 18, 2016

@kctang I have built a solution for this on the devel branch now, would be great to get your opinion on it.

@kctang
Copy link
Author

kctang commented Dec 19, 2016

Sorry but i can't try it out now...busy with other project for the next couple of weeks. :-(

@timbrandin
Copy link
Member

This is published now in v1.2.12. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants