[Dont Merge Yet] Fix PHP unit errors with wp-env phpunit container removal #182
Conversation
| @@ -54,11 +72,23 @@ public function test_register_pattern_post_type_meta_types() { | |||
| public function test_register_pattern_post_type_meta_defaults() { | |||
| register_pattern_post_type(); | |||
|
|
|||
| foreach ( array_diff( get_pattern_defaults(), [ 'title' => null ] ) as $meta_key => $default_value ) { | |||
There was a problem hiding this comment.
The reason I had to change this was because it was failing with the error Fatal error: Array to string conversion. This is apparently the error message if you use array_diff with a multi-dimentional array. See:
https://stackoverflow.com/questions/19830585/array-to-string-conversion-error-when-calling-array-diff-assoc-with-a-multid
See lines 41 and 57:
I broke it out to be a bit easier for me to understand as well. I had a hard time fully understanding what was happening without breaking it out a bit.
There was a problem hiding this comment.
Thanks for your patience with this.
My obsession with terse code gave you some nasty debugging.
johnstonphilip
changed the title
|
Before merging, remove the branch in package.json referring to this PR in wpps-scripts: |
Tasks
Summary of changes
In the wp-env project (inside Gutenberg repo), the PHPUnit and Composer packages were removed.
This resulted in PHPunit tests failing to run using wpp-scripts with the message:
The 'phpunit' container has been removed. Please use 'wp-env run tests-cli --env-cwd=wp-content/path/to/plugin phpunit' instead.In fixing it, I was getting this error:
PHP Fatal error: Declaration of PatternManager\PatternDataHandlers\PatternDataHandlersTest::setUp() must be compatible with Yoast\PHPUnitPolyfills\TestCases\TestCase::setUp(): void in /var/www/html/wp-content/plugins/pattern-manager/wp-modules/pattern-data-handlers/tests/PatternDataHandlersTest.php on line 23The fix is to make sure that setUp and tearDown declarations have a void declared for their return type.
I was also seeing errors for
Array to string conversionontest_register_pattern_post_type_meta_types. This is apparently the error message you get if you usearray_diffbut one of them is multi-dimentional.How to test
npm run test:phpunit