Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Scroll jumps to the top when closing details modal windows #4

Open
inad9300 opened this issue Sep 20, 2017 · 6 comments
Open

Scroll jumps to the top when closing details modal windows #4

inad9300 opened this issue Sep 20, 2017 · 6 comments

Comments

@inad9300
Copy link

Hi there!

You guys did a great job with this tool. It is definitely the one I liked the most from the ones that I tried. If by any chance you happen to have a little bit of time, I hereby report an annoying issue that I have been experiencing:

Whenever you open a modal window to see the details of a test, the scroll would be reset to the top of the page. If the number of tests is large and you are interested in a couple of tests that failed down below, it is quite annoying to be sent back to the top.

I would like to add, if I may, that scrolling so much is on itself not optimal. Grouping the tests together by their top-level suite would be super awesome!

Cheers,
Daniel

@stuisme
Copy link
Owner

stuisme commented Sep 24, 2017

We are experiencing the same issues with the scrolling as well. Are you viewing the report within a CI/CD tool or serving the html page directly?

As far as the grouping is concerned, also agree that this would help. I assume you would want some type of expand / collapse of the suites to help get to the failures quickly.

Thinking options could be something like { expandSuites : false, expandFailures: true } where expandSuites would represent if the suites where collapsed or expanded by default when the report is opened. expandFailures would represent if the suites containing the failure should be expanded.

@inad9300 Thoughts?

@inad9300
Copy link
Author

I'm viewing the HTML page directly.

Having expand / collapsed functionality would be superb! And the options and default values you propose are perfect; I would love to see this in place :D

@yeikel
Copy link
Contributor

yeikel commented Jan 16, 2018

Can you record a little clip explaining the steps to reproduce? Thank you

@inad9300
Copy link
Author

Recording a clip would be of little help I think. It's super simple to reproduce/understand: run enough tests to force the scroll to appear, scroll down, open one of the tests, close it, and see how the scroll is at the top again.

@yeikel
Copy link
Contributor

yeikel commented Feb 4, 2018

@inad9300 The reason I am asking is because I can't reproduce it

@inad9300
Copy link
Author

There you go (first time I use Windows' Steps Recorder):

scroll-jump-setps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants