You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Obviously any values past 20 are ignored (and an uncaught TypeError is thrown when the loop tries to access data[20].title.)
I'd say there are probably two routes here:
Refactor the main this.each() call a little bit to iterate over all the necessary json files.
Wrap the list.append() method in a try/catch so we can give a verbose error, at the very least. (This would also be helpful in instances where the getJSON call is damaged or unsuccessful, I'd imagine.)
More than willing to submit a PR for this -- just wanted to get your thoughts :)
The text was updated successfully, but these errors were encountered:
Since hypem has built-in pagination and you currently only grab the first page:
Obviously any values past 20 are ignored (and an uncaught
TypeError
is thrown when the loop tries to accessdata[20].title
.)I'd say there are probably two routes here:
this.each()
call a little bit to iterate over all the necessary json files.list.append()
method in a try/catch so we can give a verbose error, at the very least. (This would also be helpful in instances where the getJSON call is damaged or unsuccessful, I'd imagine.)More than willing to submit a PR for this -- just wanted to get your thoughts :)
The text was updated successfully, but these errors were encountered: