Support for :workflow_file_name

[cedriclevarlet]

It would be great if this action could allow for :workflow_file_name as an alternative to :workflow_id.

This seems to be support by the API and github's javascript library as specified in https://developer.github.com/v3/actions/workflows/#get-a-workflow and would avoid having to make seperate API calls to find out the ID.

[styfle]

I tried using the name and it didn’t work when I created this repo. I’ll have to try again to see if it works with the name.

Also, I kinda like the ID to avoid the situation when a workflow is renamed and the cancel action breaks.

Lastly, “name” is ambiguous because it could mean the yml file name or the name property defined in the file.

[rosenbjerg]

You could use the GITHUB_ACTION environment variable documented here: https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables
And we could avoid providing id completely and still be resistant to renaming.

Edit: I guess I could also just use that as the value for the input argument.
I still think it would be nice to not have to provide it

[styfle]

I don't think GITHUB_ACTION will work because the purpose of this workflow is to run along side and cancel other workflows.

See the Usage in the readme for an example. The cancel.yml would cancel another yml workflow.

Also see this repo which uses this pattern: https://github.com/styfle/cancel-workflow-action/tree/master/.github/workflows

[rosenbjerg]

Ah, I see

[buremba]

It would be great if we can support this feature. We're programmatically creating the workflow files and commit them into the repositories so we need to commit, perform an API call in our app from the master to Github API and use the id in order to perform another commit which is a bit painful.

Not sure which API tried but in our tests, the API accepts a workflow file name in addition to IDs. Can you please try if that's the case for you?

[mxcl]

Couldn’t we put this inside the workflow we want to cancel and then have it know to cancel itself? Otherwise renaming workflows will have unexpected side-effects.

[buremba]

@mxcl Workflow actions have access to the info of the changed files so in case a file is renamed, we can find out the previous name and cancel the actions.

[styfle]

In version 0.4.0, you no longer need to provide a workflow id.

Does this solve the original problem?

[rosenbjerg]

@styfle That is exactly the functionality I was asking for :)