Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion v11 #84

Closed
hennessyevan opened this issue Jan 21, 2020 · 5 comments · Fixed by #146
Closed

Emotion v11 #84

hennessyevan opened this issue Jan 21, 2020 · 5 comments · Fixed by #146

Comments

@hennessyevan
Copy link

hennessyevan commented Jan 21, 2020

Will this project be updated to use emotion v11? They already have a fix in it for #77 see emotion-js/emotion#1220 as well as improved typings for Theme

I'm working on a UI library that won't be out for a while so I'm working with v11 that should be out in less than a month, it would be nice to use xstyled alongside it but they've also renamed a lot of the packages so it won't work at the moment

@gregberge
Copy link
Collaborator

Yeah it is something planed!

@gregberge
Copy link
Collaborator

With the rename of packages it will be a breaking change. I am OK to bump a new major with emotion v11 support. Could you work on it?

@hennessyevan
Copy link
Author

Yeah, would love to. I'm working on this library again soon so I'll open a PR for this when I get back to it

@ivanbanov
Copy link
Contributor

Emotion 11 was just merged some hours ago :)
emotion-js/emotion#1600

@camerontaylor
Copy link

camerontaylor commented Nov 17, 2020

FYI: This support should be straightforward. I've upgraded to emotion 11 with xstyled as-is and only needed these webpack aliases:

        resolve: {
            alias: {
                '@emotion/core': '@emotion/react',
                'emotion-theming': '@emotion/react',

The latest emotion also simplified all the hassle involved in getting the babel config playing nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants