-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding heading anchors breaks sidebar navigation #339
Comments
Can you elaborate on what is broken and how it expects it to be present? |
Anchor navigation works by scrolling the viewport to the location of the referenced element. If the referenced element is not displayed on the page (because it has display: none) then its location is not defined and there is nowhere to scroll to. Thus, hiding the anchor elements breaks the sidebar navigation: clicking on the menu items does nothing because there is no element to scroll to. |
Makes sense. We should move |
Ok, no problem. By the way, the anchors themselves don't look too good on narrow screens, they are a little bit off-screen, but I'm not going to fix that since I don't know what would be a good solution. |
We could move anchors to the end of the headings — @sapegin this is "by design" — tried to align them to the baseline but it seems a bit off in your case indeed. |
Probably because we use corporate font in style guide. |
I don't like the way new heading anchors look like so I have hidden them by modifying
styles
in the config:and now the sidebar navigation is broken (because it expects the anchors to be present and visible on the page. This is beta 13.
/cc @okonet
The text was updated successfully, but these errors were encountered: