Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom build of the highlight.js to reduce its bundle size #341

Closed
okonet opened this issue Mar 2, 2017 · 4 comments
Closed

Use custom build of the highlight.js to reduce its bundle size #341

okonet opened this issue Mar 2, 2017 · 4 comments

Comments

@okonet
Copy link
Member

okonet commented Mar 2, 2017

According to https://twitter.com/samccone/status/837173944293568512 providing only needed languages to highlight.js can reduce its bundle size significantly. Seems like a low hanging fruit to optimize since SG should only support JS/JSX.

2017-03-02 at 16 16

@sapegin
Copy link
Member

sapegin commented Mar 2, 2017

We don’t have highlight.js in the bundle, it’s all server side ;-)

@sapegin sapegin closed this as completed Mar 2, 2017
@sapegin
Copy link
Member

sapegin commented Mar 2, 2017

And actually it should support any language you define for fenced code block. At least HTML, for example.

@okonet
Copy link
Member Author

okonet commented Mar 2, 2017

Server-side? Can you elaborate please?

@sapegin
Copy link
Member

sapegin commented Mar 2, 2017

We send HTML from webpack loader, so we don’t have highlight.js on the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants