fix(package.json): Updating html-webpack-plugin, fixing compilation.m… #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainTemplate.applyPluginsWaterfall error realated to incompatible version between webpack 4 and html-webpack-plugin jantimon/html-webpack-plugin#841
kontrollanten
approved these changes
Mar 5, 2018
kontrollanten
approved these changes
Mar 5, 2018
kontrollanten
added a commit
to kontrollanten/algolia-places-react
that referenced
this pull request
Mar 5, 2018
sapegin
approved these changes
Mar 5, 2018
|
@sapegin Well it's a breaking change, but currently webpack 4 and react-styleguidist are incompatible, i would consider having a /next branch - anyway its for your consideration. |
|
You can use this PR’s branch. |
|
Why would we wait till next major release if this one is already a major one? Let's not get attached to version numbers, please. They are for machines. |
|
We're going to get rid of the HTML plugin entirely — #896. But thanks for help anyway! |
kontrollanten
added a commit
to kontrollanten/algolia-places-react
that referenced
this pull request
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(package.json): Updating html-webpack-plugin, fixing compilation.mainTemplate.applyPluginsWaterfall error, related to incompatible version between webpack 4 and html-webpack-plugin.
See issue here