Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro matching fails in some cases #221

Closed
MilesPernicious opened this issue Mar 7, 2023 · 1 comment · Fixed by #241
Closed

Macro matching fails in some cases #221

MilesPernicious opened this issue Mar 7, 2023 · 1 comment · Fixed by #241
Labels
🐞 bug Something isn't working @stylify/stylify Targeting @stylify/stylify package

Comments

@MilesPernicious
Copy link
Contributor

Describe the bug

Machy8: No, it collides with "x" and "y" property that is used on svgs. But it is matched before your macro and therefore your macro is not matched. The order of matching is incorrect.

Reproduction

            'padding-y:(\\S+?)': ({ macroMatch, selectorProperties }) => {
                selectorProperties.add('padding-top', macroMatch.getCapture(0));
                selectorProperties.add('padding-bottom', macroMatch.getCapture(0));
            },

class="padding-y:2rem"

/* stylify.css */
.y\:2rem{
    y: 2rem
}

Logs

No response

System Info

@stylify/astro 0.5.28
@Machy8 Machy8 added 🐞 bug Something isn't working @stylify/stylify Targeting @stylify/stylify package labels Mar 8, 2023
@Machy8 Machy8 linked a pull request Apr 23, 2023 that will close this issue
@Machy8
Copy link
Member

Machy8 commented Apr 28, 2023

@MilesPernicious This should be fixed in 0.5.33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working @stylify/stylify Targeting @stylify/stylify package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants