Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontawesome instead of iconic? #197

Closed
optikfluffel opened this issue Jun 25, 2013 · 12 comments
Closed

fontawesome instead of iconic? #197

optikfluffel opened this issue Jun 25, 2013 · 12 comments

Comments

@optikfluffel
Copy link
Contributor

What about switching from Iconic to Font Awesome? it has way more icons and you could easily use Bootstrap CDN (or an equivalent) if you don't want to host the font files yourself.

@notslang
Copy link
Collaborator

sure, wanna make a PR for it?

@optikfluffel
Copy link
Contributor Author

Do you think using the CDN by default or including the font files itself would be the better option?

@notslang
Copy link
Collaborator

i'd go with just including it... when you're developing without internet access having stuff connected to a CDN can be annoying

@optikfluffel
Copy link
Contributor Author

good point 👍 I'll send a PR later this evening or so ^^

@yoshuawuyts
Copy link

@optikfluffel Have you sent it in yet? It's been a month since that 'evening' :)

@optikfluffel
Copy link
Contributor Author

oh sorry xD Berlin is still melting at 37°C :D maybe i can update to the latest 3.2 and open the pull request if it's getting below 30°C here xD

@yoshuawuyts
Copy link

Haha, sounds good! So we'll be seeing a PR tonight? (Lucky you by the way, Amsterdam is so rainy right now ☁️ 💧 ☁️)

@optikfluffel
Copy link
Contributor Author

I just fell asleep yesterday xD After my dayjob I'll open the PR ^^

@optikfluffel
Copy link
Contributor Author

I'm not sure wether I should include a demo.html with the fontawesome css file or not, is that necessary?

@disfated
Copy link

disfated commented Sep 7, 2013

I believe prebiult icon libraries are quite out of the date. The future is for IcoMoon.

@notslang
Copy link
Collaborator

notslang commented Sep 7, 2013

I agree that prebuilt icon libraries are not the future, but I disagree that IcoMoon is a viable alternative. Perhaps something like IcoMoon... such as an opensource library for building custom icon-fonts using only the icons that are needed. But IcoMoon is a closed-source service, and not something that I would want to rely on.

Also, I question if a specific icon-based font really belongs in nib. Nib focuses on general helpers and doesn't seem to give people a specific style... it is "style-agnostic". And a builder for icon-fonts seems even further outside the scope of nib... that would belong in a project like roots.

What we could do in nib is provide helper methods for including icon-fonts... but (correct me if I'm wrong) I don't think we want to go down any of those other routes.

@disfated
Copy link

disfated commented Sep 7, 2013

Open source alternative would be awesome...
Btw, IcoMoon author promised to publish it's sources after he will finish "entirely new version of the IcoMoon app, which is a hundred times better"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants