Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesigned Sublime Text Binaries #6581

Open
tomveninga opened this issue Jan 7, 2025 · 6 comments
Open

Codesigned Sublime Text Binaries #6581

tomveninga opened this issue Jan 7, 2025 · 6 comments
Labels

Comments

@tomveninga
Copy link

Problem description

The current Sublime binaries are not codesigned.
This is causing issues with Windows Information Protection policies as every binary is now accepted on hash base.
Every update to this binary causes the hash to change and a new policy to have to be created in order to access information protected content.

Preferred solution

All Sublime Text binaries signed with a code signing key from Sublime HQ so that the policy can be written on the 'publisher' instead of the hash.

Alternatives

The alternative would be to keep using the hashes.

Additional Information

An example of the sublime_text binary for this purpose:

PS C:\Program Files\Sublime Text> Get-AppLockerFileInformation .\sublime_text.exe | fl

Path : %PROGRAMFILES%\SUBLIME TEXT\SUBLIME_TEXT.EXE
Publisher :
Hash : SHA256 0x6B6B53AEDCDEE13A19D33363FF9ED48A1549463647567C93E12F5260F7AA911F
AppX : False

@BenjaminSchaaf
Copy link
Member

You can view the signature of our binaries by right-clicking > properties > Code Signature. See:

image

@deathaxe
Copy link
Collaborator

deathaxe commented Jan 9, 2025

Maybe the file in question is compromized?

Here's the result of ST4189 queried on Powershell 7.4.6 on Win11 23H2

grafik

4190 looks ok, too.

grafik

@deathaxe
Copy link
Collaborator

According to https://forum.sublimetext.com/t/build-4189-has-bad-signature/74876/6, if signatures were missing, they have been fixed in the meanwhile.

@BenjaminSchaaf
Copy link
Member

BenjaminSchaaf commented Jan 12, 2025

@deathaxe That was only the Linux packages, and it wasn't that the signature was missing but that it was invalid.

@deathaxe
Copy link
Collaborator

This issue is about Windows, isn't it? OPs Get-AppLockerFileInformation command returns proper signature for both portable and installed versions of ST on my box.

@BenjaminSchaaf
Copy link
Member

Yea, so the fix for the issue on the forum doesn't apply because that was purely related to Linux. Nothing was changed regarding the Windows binaries.

Still unclear what's going on here, so I think it's best to keep it open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants