Add setImmediate()

[bantu]

My browser complains about setImmediate() not being defined. This might be something for browserify to handle.

See https://github.com/andris9/smtp-connection/issues/9

[ibc]

I do not understand, setImmediate() is defined within the Node timers module, so if you do this in your JS:

var timers = require('timers');

then you get the timers.setImmediate() definition within your browserified bundle.

[ibc]

Tested, it just works.

[bantu]

@ibc https://github.com/andris9/smtp-connection/blob/master/src/smtp-connection.js#L507 uses a global function setImmediate().

[ibc]

Report the issue in that project. setImmediate() is not a ECMA standard at all:

https://developer.mozilla.org/en-US/docs/Web/API/Window.setImmediate

Anyhow, why do you want to "browserify" smtp-connection? It is not a browser valid library given that it needs to open raw TCP connections (something unfeasible in a browser).

Please close this issue.

[bantu]

Anyhow, why do you want to "browserify" smtp-connection? It is not a browser valid library given that it needs to open raw TCP connections (something unfeasible in a browser).

In my project, I have functional node sockets in the browser. I want to send e-mail messages. It actually works already. Certainly not "infeasible".

[ibc]

Sorry, I do not understand how do you have raw TCP sockets in the browser as that is imposible.

Anyhow, I've explained the issue, didn't I? why don't you comment about my rationale? OK, will repeat it:

Report the issue in that project. setImmediate() is not a ECMA standard at all (regardless it exists in Node as global function):

https://developer.mozilla.org/en-US/docs/Web/API/Window.setImmediate

[ibc]

BTW you can solve your issue with this workaround:

global.setImmediate = require('timers').setImmediate;

require('smtpconnection');

Not tested.

[bantu]

Sorry, I do not understand how do you have raw TCP sockets in the browser as that is imposible.

I just use websockify and an adapter to Node.js sockets.

Report the issue in that project.

See https://github.com/andris9/smtp-connection/issues/9#issuecomment-62950838

setImmediate() is not a ECMA standard at all (regardless it exists in Node as global function)

It's called node-browserify, so this project is directly related to Node.js. And as such the project might opt to provide a replacement/workaround for the global Node.js setImmediate() function even though it is not part of the ECMA standard.

[bantu]

Maybe this should have been reported against https://github.com/substack/insert-module-globals which seems to handle these kind of things.

[ibc]

I agree with your comment in https://github.com/andris9/smtp-connection/issues/9#issuecomment-62950838

[bantu]

For reference: http://nodejs.org/api/globals.html says "The timer functions are global variables. See the timers section."

[bantu]

@ibc Did not test your workaround. Mine looks as follows and seems to work. Thanks anyway.

...
// Inject global function setImmediate()
// See https://github.com/andris9/smtp-connection/issues/9
var insertGlobals = require('browserify/node_modules/insert-module-globals');
insertGlobals.vars.setImmediate = function () {
  return "require('timers').setImmediate";
};
var bundle = browserify({
  insertGlobals: insertGlobals
});
....

[ibc]

Looks good :)

[bantu]

@substack Could you please explain why this was closed? Should this be reported against https://github.com/substack/insert-module-globals instead? Especially see #985 (comment)

[ghost]

This falls more into the realm of javascript engines themselves since IE10 and 11 have setImmediate just like node.

[bantu]

All right, thanks.