Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize json modules #1211

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Sanitize json modules #1211

merged 1 commit into from
Apr 27, 2015
+34 −1

Conversation

zertosh
Copy link
Member

@zertosh zertosh commented Apr 12, 2015

@terinjokes
Copy link
Contributor

Is there any reason why we shouldn't just replace these four characters?

@zertosh zertosh mentioned this pull request Apr 12, 2015
Open
@zertosh
Copy link
Member Author

zertosh commented Apr 12, 2015

@terinjokes Modularize everything! But sure. I could just inline the regexp if you want.

@terinjokes
Copy link
Contributor

Sorry, the module name was throwing me off. :~)

LGTM ✨

@zertosh
Copy link
Member Author

zertosh commented Apr 27, 2015

@terinjokes Get this one out too?

terinjokes added a commit that referenced this pull request Apr 27, 2015
@terinjokes
Merge pull request #1211 from zertosh/sanitize-json
f699558 
Sanitize json modules
@terinjokes terinjokes merged commit f699558 into browserify:master Apr 27, 2015
@Macil Macil mentioned this pull request May 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zertosh @terinjokes