Add option to turn off deduping #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should probably elaborate on why. |
|
What initially prompted me to do this was an issue with the livereactload library and things being incorrectly deduped. In general though, I think it is useful for debugging. Deduping is not an easy thing to do (just look at npm3 for example). When weird things are happening with builds, it would be useful to be able to turn off deduping to help diagnose/isolate the issue. |
|
Sorry! I think I accidentally closed the PR when I commented on it last time. Still interested in getting this merged if it looks good. |
|
This patch looks good to me, it merely exposes features that are already available in sub-modules. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.