Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] add support for inspecting String/Number/Boolean objects #7

Merged
merged 1 commit into from
Apr 9, 2016
Merged

[New] add support for inspecting String/Number/Boolean objects #7

merged 1 commit into from
Apr 9, 2016

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Apr 3, 2016

Fixes #6.

I'm considering this a semver-minor: previously, Number and Boolean objects printed out as {} which is useless. String objects printed out as { 0: 'a', 1: 'b', 2: 'c' } for example, and now print as Object('abc'), which I consider much more useful.

There's the potential this could be semver-major due to the String change, but I don't think that really applies to this module's use case.

@ljharb ljharb self-assigned this Apr 9, 2016
@ljharb ljharb merged commit 0fbf348 into inspect-js:master Apr 9, 2016
@ljharb ljharb deleted the primitive_wrappers branch April 9, 2016 07:04
@brigand
Copy link
Contributor

brigand commented Apr 9, 2016

@ljharb

> var inspect = require('object-inspect')
undefined
> inspect(new Boolean(false))
'Object(true)'

@ljharb
Copy link
Member Author

ljharb commented Apr 9, 2016

yay, a bug right away! thanks, will fix

ljharb added a commit that referenced this pull request Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants