Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault in arrow substrait integration tests since latest version update #25

Closed
jorisvandenbossche opened this issue Sep 28, 2023 · 3 comments

Comments

@jorisvandenbossche
Copy link

In the Arrow project we have a nightly CI build testing with the substrait python package, and that started failing today with the update to 0.4.1. I didn't further investigate, do don't know if it's an issue with substrait or with the Arrow consumer (although I think it probably isn't an issue with this package itself), but opening an issue here as well for visibility (arrow issue -> apache/arrow#37932)

@gforsyth
Copy link
Member

Hmm, does Arrow also have substrait C++ generated code? I've hit segfaults before when C++ and Python have different versions of the "same" protos.

It is weird that 0.4.1 would cause this breakage, though, since the only update is to an extension yaml file

@jorisvandenbossche
Copy link
Author

Ah, yes, also Arrow C++ builds against a specific version of substrait. And at the moment we have

ARROW_SUBSTRAIT_BUILD_VERSION=v0.27.0

arrow/cpp/thirdparty/versions.txt

In that case, the Arrow integration tests should maybe pin the substrait-python version as well, to ensure matching substrait versions?

@gforsyth
Copy link
Member

I think that's probably a good idea. Just removes one more avenue where things can go wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants