Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean values to type declarations for TermQuery #40

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Add boolean values to type declarations for TermQuery #40

merged 2 commits into from
Jan 23, 2018

Conversation

artfwo
Copy link
Contributor

@artfwo artfwo commented Jan 23, 2018 •
edited
Loading

Support boolean values in TermQuery type declarations.

@sudo-suhas
Copy link
Owner

sudo-suhas commented Jan 23, 2018 •
edited
Loading

Hey @artfwo, thanks for the PR. Could you please verify for me that the query works correctly if you pass the boolean value(through the es console)? I wasn't able to find anything in the reference for it.

sudo-suhas
sudo-suhas requested changes Jan 23, 2018
View reviewed changes
Copy link
Owner

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the jsdoc annotations for the value parameter in the declaration file and in the source files value-term-query-base.js, term-query.js, terms-query.js?

src/index.d.ts Outdated
@@ -1327,7 +1327,7 @@ declare namespace esb {
*
* @param {string|number} queryVal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update these annotations as well?

@artfwo
Copy link
Contributor Author

artfwo commented Jan 23, 2018

@sudo-suhas Doc annotations added and we've already got these queries working in our code, so no worries on that part. I linked the relevant documentation too in the PR description.

@sudo-suhas sudo-suhas merged commit d9c0139 into sudo-suhas:master Jan 23, 2018
@artfwo artfwo deleted the termquery-boolean-val branch January 23, 2018 10:09
@sudo-suhas
Copy link
Owner

Merged in and released in v1.1.6 🎉. Thank you for the contribution @artfwo!

@artfwo
Copy link
Contributor Author

artfwo commented Jan 23, 2018

@sudo-suhas Thanks for quick response on that! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artfwo @sudo-suhas