Sort/ script: Instance Member

[seohyun0120]

Hi! I found out some problem using esb.sort()

According to the document (https://elastic-builder.js.org/docs/#sort), it says that esb.sort needs field as essential and order as optional. It works fine for specific field. But there is a problem when I use script instance member.

esb.requestBodySearch().sort(
    esb.sort()
    .type('number')
    .script(
        esb.script('inline', "doc['field_name'].value * params.factor")
            .lang('painless')
            .params({ factor: 1.1 })
    )
    .order('asc')
)

I needed to custom my field value, so I used script instance member. But the third line gives me an error message, Expected 1-2 arguments, but got 0.

I think field type should be optional not essential.

new Sort(field: string, order: string?)

Or Am I missing something? Let me know.
Thank you
Reviewer: @sudo-suhas

[sudo-suhas]

Correct me if I wrong, from what I can tell, the resolution for this problem is to annotate the field option to the esb.sort method as optional. The issue is not with the actual code but the jsdoc and typings.

[seohyun0120]

Great! I just checked the comments you left on pull-request.
Thank you for the reply!

[sudo-suhas]

For reference in the future, closed by #78.