Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate blocks behind palette #3175

Closed
pikurasa opened this issue Feb 12, 2023 · 8 comments
Closed

Don't generate blocks behind palette #3175

pikurasa opened this issue Feb 12, 2023 · 8 comments
Labels
Good first issue

Comments

@pikurasa
Copy link
Collaborator

(See below for images of current behavior.)

Blocks generated from the palette should not generate directly behind the palette. Right now, students click without doing a full "click, drag, and drop" and that means that their new blocks generate hidden behind the palette.

Current behavior

Click on block in palette without dragging it.
Screenshot at 2023-02-12 09:00:49
Block appears behind palette, which is hard to see.
Screenshot at 2023-02-12 09:00:58
User has to hide palette in order to see newly generated block(s).
Screenshot at 2023-02-12 09:01:05
@StevenSteel7
Copy link

@pikurasa Trying to fix it..

YashTote added a commit to YashTote/musicblocks that referenced this issue Feb 14, 2023
@YashTote
Blocks generated from the palette now does not generate behid the pal…
b0a84dc 
…ette

The new blocks now generated by using the palette now does not generate behind the palette. Gets generated at an other location on the canvas after clicked

"Fixes sugarlabs#3175"
@YashTote YashTote mentioned this issue Feb 14, 2023
Closed
@classr-22
Copy link

@pikurasa assign this to me, I want to work on this.

@pikurasa
Copy link
Collaborator Author

@pikurasa assign this to me, I want to work on this.

If you have a solution, please submit a PR.

@anikdhabal anikdhabal mentioned this issue Feb 22, 2023
Closed
@AishwaryaRavi07
Copy link

Is this issue still open? Can I try to fix it?

@shantanuSakpal
Copy link

shantanuSakpal commented Mar 7, 2023 •
edited
Loading

hello @walterbender, I have noticed that a similar problem arises with the search bar, which is generated behind the table. I fixed that one-

Before:
image

After:
image

P.S. Also I made the cursor as a pointer on the search button.
I am currently working on the main issue of the blocks generated behind the table. Will make a PR soon.

@pikurasa
Copy link
Collaborator Author

pikurasa commented Mar 8, 2023

Is this issue still open? Can I try to fix it?

You can review the other PRs for reference, but this issue seems to still be currently open.

@husain3012
Copy link
Contributor

@pikurasa This issue is solved in PR #3203 and can be closed now.

@pikurasa
Copy link
Collaborator Author

@pikurasa This issue is solved in PR #3203 and can be closed now.

Yeah, it's an improvement. Thank you!

DeepankCod added a commit to DeepankCod/gsoc-good-first-issues that referenced this issue Mar 20, 2023
@DeepankCod
Updated README.md
992eb07 
Removed closed/resolved issues :
sugarlabs/musicblocks#3175
RocketChat/Rocket.Chat#26741
Submitty/Submitty#8919
Submitty/Submitty#7027
oppia/oppia#17074
@DeepankCod DeepankCod mentioned this issue Mar 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blocks generated from the palette now does not generate behind the palette YashTote/musicblocks
7 participants
@walterbender @pikurasa @StevenSteel7 @husain3012 @classr-22 @AishwaryaRavi07 @shantanuSakpal