Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now Blocks is not genarated behind the palette #3190

Closed
wants to merge 2 commits into from

Conversation

anikdhabal
Copy link
Contributor

closes:- #3175

@anikdhabal anikdhabal changed the title Blocks is not genarated behind the palette Now Blocks is not genarated behind the palette Feb 22, 2023
@anikdhabal
Copy link
Contributor Author

@walterbender can you reveiw it?

@walterbender
Copy link
Member

This solution works for some blocks, but not others. This is because some blocks are "macros" (makeMacro), which means that their x position is set elsewhere. You can test by clicking on the Note block at the top of the Rhythm palette.

@walterbender
Copy link
Member

Any progress on this?

@shantanuSakpal
Copy link

hello @walterbender, I have noticed that a similar problem arises with the search bar, which is generated behind the table. I fixed that one-

Before:
image

After:
image

but I am a bit confused about where precisely the blocks are in the code. Can you help ?

P.S. Also I made the cursor as a pointer on the search button.

@walterbender
Copy link
Member

The search bar one is simply a matter of the z-index. I merged a patch for that earlier today.
Not sure what you are referring to when you ask where the blocks are in the code.

@husain3012
Copy link
Contributor

Any progress on this?

Hey, have a look at this solution, it handles both blocks and macros, without much hardcoded values
#3203

@walterbender
Copy link
Member

A patch to fix this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants