Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactSelection does not return Organization #109

Open
tislars opened this issue Mar 22, 2022 · 1 comment
Open

ContactSelection does not return Organization #109

tislars opened this issue Mar 22, 2022 · 1 comment
Labels
DX Only affecting the end developer Performance Problems with performance To Discuss The core team has to decide if this will be implemented

Comments

@tislars
Copy link

tislars commented Mar 22, 2022

What I expected
Added a contact_selection block to a Article so I can use the output like first name, last name & their organization. However, the organization isn't shown in the response.

Potential cause
The partialContact group is being used in the ContactSelectionResolver whereas the fullContact will indeed return the hash of the Account in the output.

@alexander-schranz
Copy link
Member

alexander-schranz commented Sep 26, 2022

The problem is here overfetching vs underfetching. I'm not yet sure how we solve this issue, best would be to make every field configurable like it is done in pages via properties and optimize the query based on the request fields.

At current state it is still valid that you overwrite the contact_selection resolver and use your own query and serialization to get the data you want.

@alexander-schranz alexander-schranz added DX Only affecting the end developer Performance Problems with performance To Discuss The core team has to decide if this will be implemented labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer Performance Problems with performance To Discuss The core team has to decide if this will be implemented
Projects
None yet
Development

No branches or pull requests

2 participants