Skip to content

Commit

Permalink
sstable: skip two known test flakes on windows
Browse files Browse the repository at this point in the history
Skip two tests that are known to be flakes when run on windows.

Touches cockroachdb#1897.
  • Loading branch information
nicktrav committed Jan 6, 2023
1 parent bc6b718 commit 65ff304
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions sstable/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"os"
"path"
"path/filepath"
"runtime"
"strconv"
"strings"
"testing"
Expand Down Expand Up @@ -626,6 +627,9 @@ func TestBytesIterated(t *testing.T) {
testBytesIteratedWithCompression(t, SnappyCompression, 1, blockSizes, []uint64{1e5, 1e5, 1e5, 1e5, 1e5})
})
t.Run("Uncompressed", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("See #1897.")
}
testBytesIteratedWithCompression(t, NoCompression, 0, blockSizes, []uint64{1e5, 1e5, 1e5, 1e5, 1e5})
})
t.Run("Zstd", func(t *testing.T) {
Expand Down
4 changes: 4 additions & 0 deletions sstable/unsafe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"encoding/binary"
"fmt"
"io"
"runtime"
"testing"
"time"
"unsafe"
Expand All @@ -17,6 +18,9 @@ import (
)

func TestGetBytes(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("See #1897.")
}
const size = (1 << 31) - 1
block := make([]byte, size)
data := getBytes(unsafe.Pointer(&block[0]), size)
Expand Down

0 comments on commit 65ff304

Please sign in to comment.