From 65ff304d3d7a5f7b7ed038bd175a7dd440637af4 Mon Sep 17 00:00:00 2001 From: Nick Travers Date: Thu, 5 Jan 2023 16:18:12 -0800 Subject: [PATCH] sstable: skip two known test flakes on windows Skip two tests that are known to be flakes when run on windows. Touches #1897. --- sstable/reader_test.go | 4 ++++ sstable/unsafe_test.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/sstable/reader_test.go b/sstable/reader_test.go index ea80a1d7a4..3ee56da7ee 100644 --- a/sstable/reader_test.go +++ b/sstable/reader_test.go @@ -13,6 +13,7 @@ import ( "os" "path" "path/filepath" + "runtime" "strconv" "strings" "testing" @@ -626,6 +627,9 @@ func TestBytesIterated(t *testing.T) { testBytesIteratedWithCompression(t, SnappyCompression, 1, blockSizes, []uint64{1e5, 1e5, 1e5, 1e5, 1e5}) }) t.Run("Uncompressed", func(t *testing.T) { + if runtime.GOOS == "windows" { + t.Skip("See #1897.") + } testBytesIteratedWithCompression(t, NoCompression, 0, blockSizes, []uint64{1e5, 1e5, 1e5, 1e5, 1e5}) }) t.Run("Zstd", func(t *testing.T) { diff --git a/sstable/unsafe_test.go b/sstable/unsafe_test.go index 13e26d8193..7c7b49e5af 100644 --- a/sstable/unsafe_test.go +++ b/sstable/unsafe_test.go @@ -8,6 +8,7 @@ import ( "encoding/binary" "fmt" "io" + "runtime" "testing" "time" "unsafe" @@ -17,6 +18,9 @@ import ( ) func TestGetBytes(t *testing.T) { + if runtime.GOOS == "windows" { + t.Skip("See #1897.") + } const size = (1 << 31) - 1 block := make([]byte, size) data := getBytes(unsafe.Pointer(&block[0]), size)