Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Storybook 6 #578

Closed
connor-baer opened this issue Apr 30, 2020 · 6 comments · Fixed by #660
Closed

Upgrade to Storybook 6 #578

connor-baer opened this issue Apr 30, 2020 · 6 comments · Fixed by #660
Labels
🛠️ tech Changes to the tech stack or infrastructure
Milestone

Comments

@connor-baer
Copy link
Member

connor-baer commented Apr 30, 2020

Suggested technology

The next major version of Storybook, our development environment & documentation tool, was released this week. Most notably, it greatly improves support for TypeScript and adds Storybook Args, a new API for interactive component examples.

We've started to gradually migrate Circuit UI to TypeScript (#516). All changes and new components should be done in TypeScript. Upgrading Storybook now would make our lives a lot easier while enabling powerful new features.

@connor-baer connor-baer added the 🛠️ tech Changes to the tech stack or infrastructure label Apr 30, 2020
@connor-baer connor-baer self-assigned this Apr 30, 2020
@connor-baer connor-baer added this to the v2.0 milestone May 5, 2020
@connor-baer connor-baer removed their assignment May 13, 2020
@robinmetral
Copy link
Contributor

Will this also solve the problem of the Storybook Info Addon not being compatible with TypeScript at the moment? Or should we handle it separately as recommended by Storybook?

@connor-baer
Copy link
Member Author

Yes, that's the main reason I want to update asap. Storybook 6 will have no-config TypeScript support, so I prefer to upgrade rather than fight with the configuration myself.

(FYI, the Info addon has been replaced by the Docs addon, which has the same issue)

@robinmetral
Copy link
Contributor

Perfect! I was going to start fixing the addon, but good to know that this will solve the issue. Are we waiting for the stable version to upgrade?

@connor-baer
Copy link
Member Author

connor-baer commented Jun 11, 2020

I started the upgrade in tech/storybook but ran into some issues that might have been fixed by now. If you wanna work on this, you could continue from there.

Edit: The latest beta has some changes related to the props table 👀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ tech Changes to the tech stack or infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants